Add webflow for importing bookmarks from Google #6707

CDRussell · 2025-09-01T12:05:42Z

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211197010246724?focus=true

Description

Adds the core webflow to support a guided bookmark import based on Google Takeout.

This PR is only about the flow itself
- does not contain the final UI that will come before, during and after the import flow (future PR to add this)
- does not contain timeouts / error handling if automation doesn't complete
- does not make it available yet to production code, accessible through Autofill Dev Settings screen for internal builds to test
ℹ️ don't interact with the WebView while the automation is running; in a later PR it won't be possible to interact with it during this flow

Steps to test this PR

First time import

Fresh install internal build type from this branch
Open Settings->Autofill Dev Settings
Tap on Launch Bookmarks import flow
You won't be signed in yet, so sign in to your Google account when prompted
After signing in, verify that automation takes care of the rest and you eventually leave the web flow and see the success snackbar.
Tap on View Bookmarks and verify they imported under a Imported from Chrome folder

Subsequent import (already signed in)

Tap on Launch Bookmarks import flow again. This time, you're already signed so verify it jumps straight into the automation (and that it succeeds)
Verify in View Bookmarks that there is only one Imported From Chrome folder (bookmarks will be duplicated within that folder (it's known we're matching existing bookmark importer behaviour within that folder, including not further de-duplicating so if you import n times you'll see n sets of copies of bookmarks in that one folder)

Check autofill works

Manually add your Google credentials to our password manager
Tap on Google Account Logout (from the import passwords section) to logout of Google
Tap on Launch Bookmarks import flow again.
Verify you are prompted to autofill; accept
Verify the rest of the flow is automated and you don't have to manually enter your password again

CDRussell · 2025-09-01T12:05:57Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

package.json

.../duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowViewModel.kt

package.json

Copilot

Pull Request Overview

Copilot reviewed 26 out of 31 changed files in this pull request and generated 5 comments.

...fig/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt

package.json

...src/main/java/com/duckduckgo/autofill/impl/importing/takeout/zip/TakeoutBookmarkExtractor.kt

...fig/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt

cmonfortep

Flow works great 👍

Nothing to flag, great work!

cmonfortep · 2025-10-01T13:26:33Z

.../duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowViewModel.kt

+        }
+    }
+
+    private fun isTakeoutZipDownloadLink(


Everything is an OR here, but I wonder if something should be AND. For example, url.contains(".zip") should be true always right?

I think it's ok with OR as we don't want to be too prescriptive that we miss the download. Really, we should only hit the download flow for a takeout zip and nothing else so the guards are just a light touch in terms of validating. If the URL changes to not include zip for instance, but it was still a takeout zip to download we should still continue.

sounds good, ok

cmonfortep · 2025-10-01T13:46:43Z

...src/main/java/com/duckduckgo/autofill/impl/importing/takeout/zip/TakeoutBookmarkExtractor.kt

            entry = zipInputStream.nextEntry
        }

        return ExtractionResult.Error(Exception("Chrome/Bookmarks.html not found in file"))


Just thinking about this, from observability PoV. Should we differentiate between Errors vs We extracted but no file found?

Errors I see them as something went wrong, but here is User doesn't have bookmarks?

This would be if Chrome bookmarks data wasn't chosen for the export, not that they don't have any bookmarks to export so I think this is is a valid error scenario

Gotcha, I thought it could happen on accounts without bookmarks or similar. What you describe, with the automated flow, that makes sense then. As if it's unchecked could indicate auto-flow broken.

Not sure what the real behavior will be on production, if the user will be able to interact with the page, even if it's automated. If that happens, they could uncheck bookmarks and check something else. Just something to consider if it's possible.

if the user will be able to interact with the page, even if it's automated

It won't be possible as the WebView will only show when user interaction is required to sign in / authenticate. A WIP demo available here: https://app.asana.com/1/137249556945/task/1210496756809250/comment/1211529725151990?focus=true

CDRussell mentioned this pull request Sep 1, 2025

Add feature flag for importing bookmarks using Google Takeout #6706

Merged

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from 402a647 to f0c110e Compare September 2, 2025 10:15

CDRussell force-pushed the feature/craig/streamline_import_add_feature_flag branch from 3333dc7 to 2621c66 Compare September 15, 2025 12:18

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 3 times, most recently from 7afffb4 to d7ee151 Compare September 16, 2025 16:37

CDRussell force-pushed the feature/craig/streamline_import_add_feature_flag branch from 2621c66 to eda2570 Compare September 17, 2025 16:41

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from afcb488 to 072a68b Compare September 19, 2025 10:34

CDRussell mentioned this pull request Sep 19, 2025

Add ability to parse a Takeout zip file and extract+import bookmarks #6820

Merged

5 tasks

CDRussell changed the base branch from feature/craig/streamline_import_add_feature_flag to graphite-base/6707 September 19, 2025 13:35

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from 072a68b to a3608d0 Compare September 19, 2025 13:35

CDRussell changed the base branch from graphite-base/6707 to feature/craig/streamline_import_bookmarks_takeout_zip September 19, 2025 13:35

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from a3608d0 to b84aeb9 Compare September 19, 2025 13:36

CDRussell commented Sep 19, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from 262315f to 569981b Compare September 19, 2025 14:03

CDRussell commented Sep 19, 2025

View reviewed changes

.../duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowViewModel.kt Show resolved Hide resolved

CDRussell commented Sep 19, 2025

View reviewed changes

.../duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowViewModel.kt Outdated Show resolved Hide resolved

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 3 times, most recently from 00d8ed5 to bb529d0 Compare September 19, 2025 15:17

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_takeout_zip branch from 1b6e8bb to 01d5515 Compare September 19, 2025 15:17

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 4 times, most recently from 4dd4efd to ca99169 Compare September 23, 2025 11:26

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_takeout_zip branch from 01d5515 to 1dfcbd0 Compare September 23, 2025 11:32

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 4 times, most recently from b217c11 to 0003be7 Compare September 24, 2025 14:18

CDRussell commented Sep 24, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from a714667 to a8e4b48 Compare September 26, 2025 10:49

CDRussell requested a review from Copilot September 26, 2025 10:49

Copilot AI reviewed Sep 26, 2025

View reviewed changes

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 8 times, most recently from 5f1c36c to 9b60bed Compare September 26, 2025 14:56

CDRussell marked this pull request as ready for review September 26, 2025 15:08

CDRussell assigned cmonfortep Sep 26, 2025

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 3 times, most recently from 74686f2 to d5ec240 Compare September 29, 2025 11:16

CDRussell commented Sep 29, 2025

View reviewed changes

...fig/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt Outdated Show resolved Hide resolved

CDRussell added 2 commits September 30, 2025 10:59

Add webflow for importing bookmarks from Google

b8a5c16

Formatting update after the recent spotless change

00f7fb3

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from d5ec240 to 00f7fb3 Compare September 30, 2025 10:01

cmonfortep approved these changes Oct 1, 2025

View reviewed changes

CDRussell merged commit 14be2ac into develop Oct 1, 2025
24 checks passed

CDRussell deleted the feature/craig/streamline_import_add_bookmarks_webflow branch October 1, 2025 15:04

CDRussell mentioned this pull request Oct 8, 2025

Wire bookmarks import dialog / flow into BookmarksActivity #6909

Draft

Add webflow for importing bookmarks from Google #6707

Add webflow for importing bookmarks from Google #6707

Uh oh!

Conversation

CDRussell commented Sep 1, 2025 • edited by cmonfortep Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

First time import

Subsequent import (already signed in)

Check autofill works

Uh oh!

CDRussell commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmonfortep left a comment

Choose a reason for hiding this comment

Uh oh!

cmonfortep Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

CDRussell Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

cmonfortep Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

cmonfortep Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

CDRussell Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

cmonfortep Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

CDRussell Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CDRussell commented Sep 1, 2025 •

edited by cmonfortep

Loading

CDRussell commented Sep 1, 2025 •

edited

Loading